misc fastUsdc vstorage cleanup #10661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f77b0ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15286fd7.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10578-vstorage-misc.agoric-sdk.pages.dev |
samsiegart
reviewed
Dec 10, 2024
| @@ -95,8 +95,8 @@ export const contract = async (zcf, privateArgs, zone, tools) => { | |||
| marshaller, | |||
| ); | |||
|
|
|||
| const makeStatusNode = () => E(storageNode).makeChildNode(STATUS_NODE); | |||
| const statusManager = prepareStatusManager(zone, makeStatusNode); | |||
| const statusNode = E(storageNode).makeChildNode(STATUS_NODE); | |||
There was a problem hiding this comment.
I'm confused about line 178: "Define all kinds above this line. Keep remote calls below."
Seems like this would go against that because it's a remote call. Does it matter? The makeStatusNode was already kind of a gray area in that it wasn't called immediately.
There was a problem hiding this comment.
That comment really meant "keep remote call awaits below". We'll need to improve the comment and patterns for contract developers about that, but it's out of scope for this PR.
There was a problem hiding this comment.
Got it, thanks for clarifying.
samsiegart
approved these changes
Dec 10, 2024
| @@ -95,8 +95,8 @@ export const contract = async (zcf, privateArgs, zone, tools) => { | |||
| marshaller, | |||
| ); | |||
|
|
|||
| const makeStatusNode = () => E(storageNode).makeChildNode(STATUS_NODE); | |||
| const statusManager = prepareStatusManager(zone, makeStatusNode); | |||
| const statusNode = E(storageNode).makeChildNode(STATUS_NODE); | |||
There was a problem hiding this comment.
Got it, thanks for clarifying.
"record" suggests updating local data. "publish" is our term for going out over vstorage.
turadg
force-pushed
the
10578-vstorage-misc
branch
from
90f1a97 to
f77b0ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10633
Description
Miscellaneous small fixes, docs and refactorings. These are made in the course of #10633 but that has other changes that need more work.
Best reviewed by commit.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
not yet deployed